Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

[Peter Maydell]

On 6 June 2016 at 11:37, Michael Rolnik <address@hidden> wrote:
> Signed-off-by: Michael Rolnik <address@hidden>
> ---
>  arch_init.c                     |   2 +
>  configure                       |   5 +
>  default-configs/avr-softmmu.mak |   1 +
>  disas/Makefile.objs             |   1 +
>  disas/avr.c                     |  10 ++
>  include/disas/bfd.h             |   7 +
>  include/sysemu/arch_init.h      |   1 +
>  target-avr/Makefile.objs        |   3 +
>  target-avr/cpu-qom.h            |  80 +++++++++++
>  target-avr/cpu.c                | 288 
> ++++++++++++++++++++++++++++++++++++++++
>  target-avr/cpu.h                | 134 +++++++++++++++++++
>  target-avr/gdbstub.c            |  99 ++++++++++++++
>  target-avr/helper.c             |  85 ++++++++++++
>  target-avr/helper.h             |  21 +++
>  target-avr/machine.c            |  54 ++++++++
>  target-avr/machine.h            |  21 +++
>  target-avr/translate.c          | 288 
> ++++++++++++++++++++++++++++++++++++++++
>  17 files changed, 1100 insertions(+)

(This would probably benefit from being split up a bit too
in my view, but Richard's reviewing this part, not me.)

> diff --git a/disas/avr.c b/disas/avr.c
> new file mode 100644
> index 0000000..f916e72
> --- /dev/null
> +++ b/disas/avr.c
> @@ -0,0 +1,10 @@

Please provide a header comment stating copyright and
license for all new files, even really small ones and
Makefiles. This is one of those things we don't get right
for everything in the tree right now but would like to
maintain for anything new we add. (You don't, at least
as far as we're concerned, have to use the full three
paragraph form if that seems overly bulky; something like

 * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
 * See the COPYING.LIB file in the top-level directory.

is also fine with us.)

> +#include "qemu/osdep.h"
> +#include "qemu-common.h"
> +#include "disas/bfd.h"
> +
> +int print_insn_avr(bfd_vma addr, disassemble_info *info)
> +{
> +    int length  = 0;;
> +    /*  TODO    */
> +    return length;
> +}

thanks
-- PMM