Re: [Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

[Michael Rolnik]

Richard, do you want to delete all empty lines?

On Mon, Jun 6, 2016 at 11:25 PM, Richard Henderson <address@hidden> wrote:

> On 06/06/2016 03:37 AM, Michael Rolnik wrote:
>
>> @@ -55,12 +55,14 @@ static void avr_cpu_reset(CPUState *s)
>>      AVRCPU *cpu = AVR_CPU(s);
>>      AVRCPUClass *mcc = AVR_CPU_GET_CLASS(cpu);
>>      CPUAVRState *env = &cpu->env;
>> +    uint32_t features = env->features;
>>
>>      mcc->parent_reset(s);
>>
>>      memset(env, 0, sizeof(CPUAVRState));
>>      env->pc = 0;
>>      env->sregI = 1;
>> +    env->features = features;
>>
>
> Didn't fix the memset issue I pointed out.
>
> +}
>> +static void avr_avr6_initfn(Object *obj)
>>
>
> Spacing.
>
> +}
>> +static void avr_xmega2_initfn(Object *obj)
>>
>
> Spacing.
>
> +}
>> +static void avr_xmega4_initfn(Object *obj)
>>
>
> Spacing.
>
> +}
>> +static void avr_xmega5_initfn(Object *obj)
>>
>
> Spacing.
>
> +}
>> +static void avr_xmega7_initfn(Object *obj)
>>
>
> Spacing.
>
> +static inline void  avr_del_feature(
>> +                                CPUAVRState        *env,
>> +                                int                 feature)
>> +{
>> +    env->features   &= ~(1Ul << feature);
>> +}
>>
>
> Dead code.
>
>
> r~
>
>


-- 
Best Regards,
Michael Rolnik