qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH V7 19/19] target-arm/psci.c: wake up sleepin


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH V7 19/19] target-arm/psci.c: wake up sleeping CPUs (MTTCG)
Date: Mon, 10 Aug 2015 18:41:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0


On 10/08/2015 17:27, address@hidden wrote:
> From: Alex Bennée <address@hidden>
> 
> Testing with Alexander's bare metal syncronisation tests fails in MTTCG
> leaving one CPU spinning forever waiting for the second CPU to wake up.
> We simply need to poke the halt_cond once we have processed the PSCI
> power on call.
> 
> Tested-by: Alex Bennée <address@hidden>
> CC: Alexander Spyridakis <address@hidden>
> ---
>  target-arm/psci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target-arm/psci.c b/target-arm/psci.c
> index 20e4cb6..83e309c 100644
> --- a/target-arm/psci.c
> +++ b/target-arm/psci.c
> @@ -211,6 +211,8 @@ void arm_handle_psci_call(ARMCPU *cpu)
>          }
>          target_cpu_class->set_pc(target_cpu_state, entry);
>  
> +        qemu_cond_signal(target_cpu_state->halt_cond);
> +

qemu_cpu_kick, not qemu_cond_signal.

Paolo

>          ret = 0;
>          break;
>      case QEMU_PSCI_0_1_FN_CPU_OFF:
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]