[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM |
Date: |
Mon, 10 Aug 2015 17:45:27 +0100 |
On 10 August 2015 at 13:06, Pavel Fedin <address@hidden> wrote:
> This patch introduces kernel_irqchip_type member in Machine class, which
> is passed to kvm_arch_irqchip_create. Machine models which can use vGIC
> now use it in order to supply correct GIC type for KVM capability
> verification. The variable is defined as int in order to be
> architecture-agnostic for potential future uses by other architectures.
>
> Signed-off-by: Pavel Fedin <address@hidden>
I still think this is the wrong approach -- see my remarks
in the previous round of patch review.
thanks
-- PMM
- [Qemu-devel] [PATCH v8 0/5] vGICv3 support, Pavel Fedin, 2015/08/10
- [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Pavel Fedin, 2015/08/10
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Pavel Fedin, 2015/08/12
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Peter Maydell, 2015/08/12
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Christoffer Dall, 2015/08/12
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Eric Auger, 2015/08/12
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Christoffer Dall, 2015/08/12
- Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM, Eric Auger, 2015/08/12
[Qemu-devel] [PATCH v8 1/5] Implement GIC-500 base class, Pavel Fedin, 2015/08/10