Re: [Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway.

[Paolo Bonzini]

On 10/08/2015 17:27, address@hidden wrote:
> diff --git a/cpus.c b/cpus.c
> index 2c5ca72..f61530c 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -674,8 +674,7 @@ static void cpu_signal(int sig)
>          cpu_exit(current_cpu);
>      }
>  
> -    /* FIXME: We might want to check if the cpu is running? */
> -    tcg_thread_cpu->exit_request = true;
> +    cpu_exit(tcg_thread_cpu);

If you do this, you can remove the first "if" too, because current_cpu
is always either tcg_thread_cpu or NULL.

I think it's okay to do that and squash this patch into patch 11 as well.

Paolo