[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request global.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request global. |
Date: |
Mon, 10 Aug 2015 17:51:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 10/08/2015 17:27, address@hidden wrote:
> {
> if (current_cpu) {
> cpu_exit(current_cpu);
> }
> - exit_request = 1;
> +
> + /* FIXME: We might want to check if the cpu is running? */
> + tcg_thread_cpu->exit_request = true;
> }
>
> #ifdef CONFIG_LINUX
> @@ -1151,6 +1159,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
> CPUState *cpu = arg;
>
> qemu_mutex_lock_iothread();
> + tcg_thread_cpu = cpu;
> qemu_tcg_init_cpu_signals();
> qemu_thread_get_self(cpu->thread);
This only makes sense for MTTCG, so it should be squashed in patch 11, I
think.
Paolo
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, (continued)
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, Frederic Konrad, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, Alex Bennée, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, Frederic Konrad, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, Paolo Bonzini, 2015/08/12
- Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, Frederic Konrad, 2015/08/12
[Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread., fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 13/19] add a callback when tb_invalidate is called., fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request global., fred . konrad, 2015/08/10
- Re: [Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request global.,
Paolo Bonzini <=
[Qemu-devel] [RFC PATCH V7 12/19] Use atomic cmpxchg to atomically check the exclusive value in a STREX, fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 14/19] cpu: introduce tlb_flush*_all., fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 15/19] arm: use tlb_flush*_all, fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway., fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 16/19] translate-all: introduces tb_flush_safe., fred . konrad, 2015/08/10