[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks |
Date: |
Wed, 17 Sep 2014 08:22:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/17/2014 04:54 AM, Andreas Färber wrote:
> I am fine with adding such hooks, but please let's use a better, active
> name. CPUClass is the struct name and cpu-exec is a file name; the hook
> should say what it's doing, not where the code (used to) live(s). Just
> exec_enter/exec_exit possibly?
cpu_exec is also the function name from which they're invoked, not just the
file name.
I can make the name change if you really prefer, but (perhaps obviously) I
kinda like the current naming.
r~
- [Qemu-devel] [PATCH 00/23] qom hooks to clean up cpu_exec, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 03/23] target-i386: Use cpu_exec_enter/exit qom hooks, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 04/23] target-m68k: Use cpu_exec_enter/exit qom hooks, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom hook, Richard Henderson, 2014/09/13