[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains |
Date: |
Sun, 14 Sep 2014 20:36:27 +0100 |
User-agent: |
mu4e 0.9.9.5; emacs 24.3.1 |
Richard Henderson writes:
> Around the cpu_exec_enter/exit hooks contain many empty
> ifdef blocks. Delete all of these to highlight those
> targets for which we actually need to do work.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> cpu-exec.c | 32 --------------------------------
> 1 file changed, 32 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index d5b86d0..808d34f 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -358,27 +358,12 @@ int cpu_exec(CPUArchState *env)
> env->df = 1 - (2 * ((env->eflags >> 10) & 1));
> CC_OP = CC_OP_EFLAGS;
> env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
> -#elif defined(TARGET_SPARC)
> #elif defined(TARGET_M68K)
> env->cc_op = CC_OP_FLAGS;
> env->cc_dest = env->sr & 0xf;
> env->cc_x = (env->sr >> 4) & 1;
> -#elif defined(TARGET_ALPHA)
> -#elif defined(TARGET_ARM)
> -#elif defined(TARGET_UNICORE32)
> #elif defined(TARGET_PPC)
> env->reserve_addr = -1;
> -#elif defined(TARGET_LM32)
> -#elif defined(TARGET_MICROBLAZE)
> -#elif defined(TARGET_MIPS)
> -#elif defined(TARGET_MOXIE)
> -#elif defined(TARGET_OPENRISC)
> -#elif defined(TARGET_SH4)
> -#elif defined(TARGET_CRIS)
> -#elif defined(TARGET_S390X)
> -#elif defined(TARGET_XTENSA)
> -#elif defined(TARGET_TRICORE)
> - /* XXXXX */
> #endif
> cc->cpu_exec_enter(cpu);
> cpu->exception_index = -1;
> @@ -830,28 +815,11 @@ int cpu_exec(CPUArchState *env)
> /* restore flags in standard format */
> env->eflags = env->eflags | cpu_cc_compute_all(env, CC_OP)
> | (env->df & DF_MASK);
> -#elif defined(TARGET_ARM)
> - /* XXX: Save/restore host fpu exception state?. */
> -#elif defined(TARGET_UNICORE32)
> -#elif defined(TARGET_SPARC)
> -#elif defined(TARGET_PPC)
> -#elif defined(TARGET_LM32)
> #elif defined(TARGET_M68K)
> cpu_m68k_flush_flags(env, env->cc_op);
> env->cc_op = CC_OP_FLAGS;
> env->sr = (env->sr & 0xffe0)
> | env->cc_dest | (env->cc_x << 4);
> -#elif defined(TARGET_MICROBLAZE)
> -#elif defined(TARGET_MIPS)
> -#elif defined(TARGET_TRICORE)
> -#elif defined(TARGET_MOXIE)
> -#elif defined(TARGET_OPENRISC)
> -#elif defined(TARGET_SH4)
> -#elif defined(TARGET_ALPHA)
> -#elif defined(TARGET_CRIS)
> -#elif defined(TARGET_S390X)
> -#elif defined(TARGET_XTENSA)
> - /* XXXXX */
> #endif
> cc->cpu_exec_exit(cpu);
--
Alex Bennée
- [Qemu-devel] [PATCH 00/23] qom hooks to clean up cpu_exec, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 00/23] qom hooks to clean up cpu_exec, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains, Richard Henderson, 2014/09/13
- Re: [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains,
Alex Bennée <=
- [Qemu-devel] [PATCH 03/23] target-i386: Use cpu_exec_enter/exit qom hooks, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 04/23] target-m68k: Use cpu_exec_enter/exit qom hooks, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom hook, Richard Henderson, 2014/09/13
- [Qemu-devel] [PATCH 06/23] qom: Add cpu_exec_interrupt hook, Richard Henderson, 2014/09/13