Re: [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom hook

[Alex Bennée]

Richard Henderson writes:

> Cc: address@hidden
> Signed-off-by: Richard Henderson <address@hidden>
<snip>
> +static void ppc_cpu_exec_enter(CPUState *cs)
> +{
> +    PowerPCCPU *cpu = POWERPC_CPU(cs);
> +    CPUPPCState *env = &cpu->env;
> +

Ok the naming of those structures and the order to traverse them gets
confusing - is it really CPUState -> ${ARCH}CPU -> ${ARCH}CPUState?

Anyway...

Reviewed-by: Alex Bennée <address@hidden>


> +    env->reserve_addr = -1;
> +}
> +
>  /* CPUClass::reset() */
>  static void ppc_cpu_reset(CPUState *s)
>  {
> @@ -9638,6 +9646,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void 
> *data)
>      cc->write_elf64_qemunote = ppc64_cpu_write_elf64_qemunote;
>  #endif
>  #endif
> +    cc->cpu_exec_enter = ppc_cpu_exec_enter;
>  
>      cc->gdb_num_core_regs = 71;


-- 
Alex Bennée