[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/16] pci-assign: assignment should fail if we
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/16] pci-assign: assignment should fail if we can't read config space |
Date: |
Tue, 29 Apr 2014 13:12:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> assigned_initfn()
> get_real_device()
> read()
>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
> hw/i386/kvm/pci-assign.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index f91d4fb..e89bb6a 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -574,10 +574,11 @@ again:
> if (r < 0) {
> if (errno == EINTR || errno == EAGAIN) {
> goto again;
> }
> error_report("%s: read failed, errno = %d", __func__, errno);
> + return 1;
> }
>
> /* Restore or clear multifunction, this is always controlled by qemu */
> if (pci_dev->dev.cap_present & QEMU_PCI_CAP_MULTIFUNCTION) {
> pci_dev->dev.config[PCI_HEADER_TYPE] |=
> PCI_HEADER_TYPE_MULTI_FUNCTION;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 02/16] monitor: add Error-propagating monitor_handle_fd_param2(), (continued)
- [Qemu-devel] [PATCH 08/16] pci-assign: accept Error from pci_add_capability2(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 04/16] pci-assign: make assign_failed_examine() just format the cause, Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 06/16] pci-assign: propagate Error from check_irqchip_in_kernel(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 10/16] pci-assign: propagate errors from get_real_device(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 09/16] pci-assign: assignment should fail if we can't read config space, Laszlo Ersek, 2014/04/10
- Re: [Qemu-devel] [PATCH 09/16] pci-assign: assignment should fail if we can't read config space,
Eric Blake <=
- [Qemu-devel] [PATCH 07/16] pci: add Error-propagating pci_add_capability2(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 05/16] pci-assign: propagate errors from get_real_id(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 11/16] pci-assign: propagate errors from assigned_device_pci_cap_init(), Laszlo Ersek, 2014/04/10
- [Qemu-devel] [PATCH 13/16] pci-assign: propagate errors from assigned_dev_register_regions(), Laszlo Ersek, 2014/04/10