Re: [Qemu-devel] [PATCH 07/16] pci: add Error-propagating pci_add_capability2()

[Laszlo Ersek]

On 04/29/14 19:41, Eric Blake wrote:
> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>> ... and rebase pci_add_capability() to it.
>>
>> Signed-off-by: Laszlo Ersek <address@hidden>
>> ---
>>  include/hw/pci/pci.h |  4 ++++
>>  hw/pci/pci.c         | 32 ++++++++++++++++++++++++++------
>>  2 files changed, 30 insertions(+), 6 deletions(-)
>>
> 
>> @@ -306,10 +307,13 @@ void pci_register_vga(PCIDevice *pci_dev, MemoryRegion 
>> *mem,
>>  void pci_unregister_vga(PCIDevice *pci_dev);
>>  pcibus_t pci_get_bar_addr(PCIDevice *pci_dev, int region_num);
>>  
>>  int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
>>                         uint8_t offset, uint8_t size);
>> +int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
>> +                       uint8_t offset, uint8_t size,
>> +                       Error **errp);
> 
> Indentation is off; might be transient if you merge things back into one
> pci_add_capability later in the series.  Modulo that,
> Reviewed-by: Eric Blake <address@hidden>
> 

Hm, I'm afraid I missed to reindent the parameter list by one space for
good, in both declaration and definition. Do you want me to respin
because of that?

Thank you,
Laszlo