Re: [Qemu-devel] [PATCH 02/16] monitor: add Error-propagating monitor_handle_fd_param2()

[Eric Blake]

On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> and rebase monitor_handle_fd_param() to it. (Note that this will slightly
> change the behavior when the qemu_parse_fd() branch is selected and it
> fails: we now report (and in case of QMP, set) the error immediately,
> rather than allowing the caller to set its own error message (if any)).
> 
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>  include/monitor/monitor.h |  1 +
>  monitor.c                 | 29 +++++++++++++++++++++++------
>  2 files changed, 24 insertions(+), 6 deletions(-)

Ideally, we'll get rid of the clients of the old spelling at some future
day, at which point we can then s/param2/param/ for all clients of the
new spelling; but your cover letter was clear that this current series
is only worried about one part of cleanups and leaving compat functions
for the rest of the tree rather than tackling everything in one go.
Therefore, as this appears to be a strict improvement, and falls within
the scope of what your cover letter promised,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature