Re: [Qemu-devel] [PATCH 13/16] pci-assign: propagate errors from assigned_dev_register_regions()

[Eric Blake]

On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>  hw/i386/kvm/pci-assign.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 

> @@ -423,13 +424,13 @@ static int assigned_dev_register_regions(PCIRegion 
> *io_regions,
>                                                      cur_region->resource_fd,
>                                                      (off_t)0);
>  
>              if (pci_dev->v_addrs[i].u.r_virtbase == MAP_FAILED) {
>                  pci_dev->v_addrs[i].u.r_virtbase = NULL;
> -                error_report("%s: Error: Couldn't mmap 0x%" PRIx64 "!",
> -                             __func__, cur_region->base_addr);
> -                return -1;
> +                error_setg_errno(errp, errno, "Couldn't mmap 0x%" PRIx64 "!",

The ! in the message is overkill, I wouldn't mind if someone deletes it,
but it's minor enough to not warrant a respin.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature