[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' |
Date: |
Tue, 15 Apr 2014 19:03:34 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/15/2014 04:43 PM, Markus Armbruster wrote:
> Peter Crosthwaite <address@hidden> writes:
>
>> On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang <address@hidden> wrote:
>>> In function, if no additional resources to free before quit, commonly,
>>> need not use additional local variable 'res' to notice about it. So
>>> remove it to simplify code.
>>>
>>
>> Styling wise, there is a school of thought that functions should only
>> have one return statement which is probably the original authors
>> intention.
>
> Plausible. But what matters here is whether we think the patch is
> worthwhile or not.
>
> I find Chen's version a bit clearer, but I'm not sure it's worth the
> churn.
>
Hmm... after think of, for me, it will be fine to still remain the
original state, it is not quit worth to churn.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
- [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', (continued)
- [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/08
- [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/08
- [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/08
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Peter Crosthwaite, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res',
Chen Gang <=
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', liang ding, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15