[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue' |
Date: |
Tue, 15 Apr 2014 12:11:03 +1000 |
On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang <address@hidden> wrote:
> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not
> need additional useless 'continue'.
>
Only in the case where the if-else is not followed by any code. Which
is the case here. I found this sentance slightly confusing and TBH id
just drop it or say something less codey like:
"This if else has no code between it and the end of the enclosing
while loop. This makes this continue redundant."
> Signed-off-by: Chen Gang <address@hidden>
But patch is good:
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> vl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 9975e5a..7505002 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp)
> if (argv[optind][0] != '-') {
> /* disk image */
> optind++;
> - continue;
> } else {
> const QEMUOption *popt;
>
> --
> 1.7.9.5
>
- [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', (continued)
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Peter Crosthwaite, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue',
Peter Crosthwaite <=
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', liang ding, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15