[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' |
Date: |
Tue, 15 Apr 2014 12:50:15 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/15/2014 10:13 AM, Peter Crosthwaite wrote:
> On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang <address@hidden> wrote:
>> In function, if no additional resources to free before quit, commonly,
>> need not use additional local variable 'res' to notice about it. So
>> remove it to simplify code.
>>
>
> Styling wise, there is a school of thought that functions should only
> have one return statement which is probably the original authors
> intention.
>
Hmm... maybe.
For me, the readers' feeling (let code simple and easy understanding) is
more important than "school rules".
Welcome other members' styling tastes.
> Regards,
> Peter
>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>> vl.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 7505002..377f962 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1188,18 +1188,16 @@ DeviceState *get_boot_device(uint32_t position)
>> {
>> uint32_t counter = 0;
>> FWBootEntry *i = NULL;
>> - DeviceState *res = NULL;
>>
>> if (!QTAILQ_EMPTY(&fw_boot_order)) {
>> QTAILQ_FOREACH(i, &fw_boot_order, link) {
>> if (counter == position) {
>> - res = i->dev;
>> - break;
>> + return i->dev;
>> }
>> counter++;
>> }
>> }
>> - return res;
>> + return NULL;
>> }
>>
>> /*
>> --
>> 1.7.9.5
>>
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
- Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, (continued)
- Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, Chen Gang, 2014/04/06
- [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/08
- [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/08
- [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/08
- [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/08
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Peter Crosthwaite, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res',
Chen Gang <=
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', liang ding, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15