[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defin
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values |
Date: |
Thu, 27 Feb 2014 06:45:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 04:09 AM, Wenchao Xia wrote:
> From: Wenchao Xia <address@hidden>
>
> Later other scripts will need to check the enum values.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Wenchao Xia <address@hidden>
Having two S-o-B by yourself looks awkward; is there one address we
should be favoring?
> ---
> scripts/qapi.py | 16 +++++++++++-----
> tests/qapi-schema/comments.out | 2 +-
> tests/qapi-schema/qapi-schema-test.out | 10 +++++-----
> 3 files changed, 17 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values, Wenchao Xia, 2014/02/27
- Re: [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values,
Eric Blake <=
- [Qemu-devel] [PATCH V8 02/10] qapi script: add check for duplicated key, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 03/10] qapi script: remember line number in schema parsing, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 05/10] qapi script: code move for generate_enum_name(), Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string, Wenchao Xia, 2014/02/27