Re: [Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string

[Eric Blake]

On 02/27/2014 04:09 AM, Wenchao Xia wrote:
> From: Wenchao Xia <address@hidden>
> 
> Prior to this patch, qapi-visit.py used custom code to generate enum
> names used for handling a qapi union. Fix it to instead reuse common
> code, with identical generated results, and allowing future updates to
> generation to only need to touch one place.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---

Double S-o-B here and in 5.

>  scripts/qapi-types.py |    6 +++---
>  scripts/qapi-visit.py |   19 +++++++++++++------
>  scripts/qapi.py       |   13 +++++++++----
>  3 files changed, 25 insertions(+), 13 deletions(-)

Reviewed-by: Eric Blake <address@hidden>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature