[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -sn
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot |
Date: |
Thu, 27 Feb 2014 06:42:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 04:33 AM, Amit Shah wrote:
> On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote:
>> On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote:
>>> If TMPDIR is not specified, the default was to use /tmp for the working
>>> copy of the block devices. Update this to /var/tmp instead, so systems
>>> using tmp-on-tmpfs don't end up inadvertently using RAM for the block
>>> device.
>>>
>>> Signed-off-by: Amit Shah <address@hidden>
>>> ---
>>> block.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> Was expecting someone to argue against this because a path change is
>> always controversial :-). But I think this makes sense and no one is
>> protesting....
No protests here. Libvirt doesn't use -snapshot to trigger the behavior
in the first place, and even if it did, it is always possible to
explicitly set TMPDIR if you don't like the (changed) default.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature