[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 19/31] target-arm: A64: Implement WFI
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 19/31] target-arm: A64: Implement WFI |
Date: |
Wed, 26 Feb 2014 09:20:09 +1000 |
On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell <address@hidden> wrote:
> Implement the WFI instruction for A64; this just involves wiring
> up the instruction, and adding a gen_a64_set_pc_im() which was
> accidentally omitted from the A64 decoder top loop.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Sorry about the delay
> ---
> target-arm/translate-a64.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 1714df2..948470f 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -1065,9 +1065,11 @@ static void handle_hint(DisasContext *s, uint32_t insn,
> switch (selector) {
> case 0: /* NOP */
> return;
> + case 3: /* WFI */
> + s->is_jmp = DISAS_WFI;
> + return;
> case 1: /* YIELD */
> case 2: /* WFE */
> - case 3: /* WFI */
> case 4: /* SEV */
> case 5: /* SEVL */
> /* we treat all as NOP at least for now */
> @@ -8955,6 +8957,7 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu,
> /* This is a special case because we don't want to just halt the
> CPU
> * if trying to debug across a WFI.
> */
> + gen_a64_set_pc_im(dc->pc);
> gen_helper_wfi(cpu_env);
> break;
> }
> --
> 1.8.5
>
>
- [Qemu-devel] [PATCH v3 00/31] A64 system emulation prequisites, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 07/31] target-arm: Implement AArch64 dummy MDSCR_EL1, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 21/31] target-arm: Implement AArch64 DAIF system register, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 29/31] target-arm: A64: Add assertion that FP access was checked, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 13/31] target-arm: Implement AArch64 MPIDR, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 19/31] target-arm: A64: Implement WFI, Peter Maydell, 2014/02/15
- Re: [Qemu-devel] [PATCH v3 19/31] target-arm: A64: Implement WFI,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v3 11/31] target-arm: Implement AArch64 VBAR_EL1, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 20/31] target-arm: Store AIF bits in env->pstate for AArch32, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 09/31] target-arm: Implement AArch64 SCTLR_EL1, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 10/31] target-arm: Implement AArch64 TCR_EL1, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 12/31] target-arm: Implement AArch64 TTBR*, Peter Maydell, 2014/02/15
- [Qemu-devel] [PATCH v3 01/31] target-arm: Fix raw read and write functions on AArch64 registers, Peter Maydell, 2014/02/15