qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_


From: Orit Wasserman
Subject: Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user
Date: Wed, 18 Dec 2013 12:28:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 12/17/2013 05:25 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
  include/exec/memory-internal.h | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index 6fb1b64..2f6610a 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -86,13 +86,6 @@ static inline void cpu_physical_memory_set_dirty(ram_addr_t 
addr)
      cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE);
  }

-static inline void cpu_physical_memory_clear_dirty_flag(ram_addr_t addr,
-                                                       unsigned client)
-{
-    assert(client < DIRTY_MEMORY_NUM);
-    clear_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]);
-}
-
  static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
                                                         ram_addr_t length)
  {
@@ -112,10 +105,11 @@ static inline void 
cpu_physical_memory_mask_dirty_range(ram_addr_t start,
  {
      ram_addr_t addr, end;

+    assert(client < DIRTY_MEMORY_NUM);
      end = TARGET_PAGE_ALIGN(start + length);
      start &= TARGET_PAGE_MASK;
      for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
-        cpu_physical_memory_clear_dirty_flag(addr, client);
+        clear_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]);
      }
  }


Reviewed-by: Orit Wasserman <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]