Re: [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

[Orit Wasserman]

On 12/17/2013 05:25 PM, Juan Quintela wrote:
> Now all functions use the same wording that bitops/bitmap operations
>
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   exec.c                         | 2 +-
>   include/exec/memory-internal.h | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index ad9866c..6bef3e5 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -747,7 +747,7 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, 
> ram_addr_t end,
>       length = end - start;
>       if (length == 0)
>           return;
> -    cpu_physical_memory_mask_dirty_range(start, length, client);
> +    cpu_physical_memory_clear_dirty_range(start, length, client);
>
>       if (tcg_enabled()) {
>           tlb_reset_dirty_range_all(start, end, length);
> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
> index fa28fc6..c04a92a 100644
> --- a/include/exec/memory-internal.h
> +++ b/include/exec/memory-internal.h
> @@ -100,9 +100,9 @@ static inline void 
> cpu_physical_memory_set_dirty_range(ram_addr_t start,
>       xen_modified_memory(addr, length);
>   }
>
> -static inline void cpu_physical_memory_mask_dirty_range(ram_addr_t start,
> -                                                        ram_addr_t length,
> -                                                        unsigned client)
> +static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
> +                                                         ram_addr_t length,
> +                                                         unsigned client)
>   {
>       ram_addr_t addr, end;

Reviewed-by: Orit Wasserman <address@hidden>