Re: [Qemu-devel] [PATCH 15/38] memory: cpu_physical_memory_clear_dirty_flag() result is never used

[Orit Wasserman]

On 12/17/2013 05:25 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   include/exec/memory-internal.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
> index d09d6d8..666490c 100644
> --- a/include/exec/memory-internal.h
> +++ b/include/exec/memory-internal.h
> @@ -86,14 +86,14 @@ static inline void cpu_physical_memory_set_dirty(ram_addr_t 
> addr)
>       cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE);
>   }
>
> -static inline int cpu_physical_memory_clear_dirty_flag(ram_addr_t addr,
> +static inline void cpu_physical_memory_clear_dirty_flag(ram_addr_t addr,
>                                                          unsigned client)
>   {
>       int mask = ~(1 << client);
>
>       assert(client < DIRTY_MEMORY_NUM);
>
> -    return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] &= mask;
> +    ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] &= mask;
>   }
>
>   static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,

Reviewed-by: Orit Wasserman <address@hidden>