qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors
Date: Mon, 24 Jun 2013 10:06:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Typo in subject: s/udb/UDP/

Gerd Hoffmann <address@hidden> writes:

> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  qemu-char.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 7d072a8..dcc91bb 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts 
> *opts)
>  
>      fd = inet_dgram_opts(opts, &local_err);
>      if (fd < 0) {
> +        qerror_report_err(local_err);
> +        error_free(local_err);
>          return NULL;
>      }
>      return qemu_chr_open_udp_fd(fd);

Also plugs memory leak on error path.  Worth mentioning in commit
message.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]