[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors |
Date: |
Mon, 24 Jun 2013 10:06:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Typo in subject: s/udb/UDP/
Gerd Hoffmann <address@hidden> writes:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qemu-char.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 7d072a8..dcc91bb 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts
> *opts)
>
> fd = inet_dgram_opts(opts, &local_err);
> if (fd < 0) {
> + qerror_report_err(local_err);
> + error_free(local_err);
> return NULL;
> }
> return qemu_chr_open_udp_fd(fd);
Also plugs memory leak on error path. Worth mentioning in commit
message.
- [Qemu-devel] [PATCH v2 03/13] qemu-socket: catch monitor_get_fd failures, (continued)
- [Qemu-devel] [PATCH v2 03/13] qemu-socket: catch monitor_get_fd failures, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 04/13] qemu-char: check optional fields using has_*, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 06/13] qemu-char: print notification to stderr, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 05/13] qemu-char: use more specific error_setg_* variants, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 09/13] qemu-char: use ChardevBackendKind in in CharDriver, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 07/13] qemu-char: fix documentation for telnet+wait socket flags, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 08/13] qemu-char: don't leak opts on error, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 13/13] qemu-socket: don't leak opts on error, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors, Gerd Hoffmann, 2013/06/24
- Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 11/13] qemu-char: add -chardev mux support, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 10/13] qemu-char: minor mux chardev fixes, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation, Gerd Hoffmann, 2013/06/24
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes, Michael Tokarev, 2013/06/24
- Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes, Laszlo Ersek, 2013/06/24