Re: [Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  util/qemu-sockets.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 86fb09c..35023a8 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -871,7 +871,6 @@ SocketAddress *socket_parse(const char *str, Error **errp)
>          }
>      } else {
>          addr->kind = SOCKET_ADDRESS_KIND_INET;
> -        addr->inet = g_new(InetSocketAddress, 1);
>          addr->inet = inet_parse(str, errp);
>          if (addr->inet == NULL) {
>              goto fail;

Plugs a memory leak, which is a bit more than "drop pointless
allocation".