[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fix
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes |
Date: |
Mon, 24 Jun 2013 10:54:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
On 06/24/13 08:39, Gerd Hoffmann wrote:
> Hi,
>
> Here is v2 of the series, addressing Michaels review comments.
>
> cheers,
> Gerd
>
> Gerd Hoffmann (13):
> qemu-socket: zero-initialize SocketAddress
> qemu-socket: drop pointless allocation
> qemu-socket: catch monitor_get_fd failures
> qemu-char: check optional fields using has_*
> qemu-char: use more specific error_setg_* variants
> qemu-char: print notification to stderr
> qemu-char: fix documentation for telnet+wait socket flags
> qemu-char: don't leak opts on error
> qemu-char: use ChardevBackendKind in in CharDriver
> qemu-char: minor mux chardev fixes
> qemu-char: add -chardev mux support
> qemu-char: report udb backend errors
> qemu-socket: don't leak opts on error
>
> include/sysemu/char.h | 2 +-
> qapi-schema.json | 7 ++++---
> qemu-char.c | 45 ++++++++++++++++++++++++++++++++-------------
> util/qemu-sockets.c | 9 ++++-----
> 4 files changed, 41 insertions(+), 22 deletions(-)
>
I think 11/13 doesn't qualify for qemu-trivial. In any case, it does
seem correct, like the rest.
With the commit message fixups from Michael: series
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks
Laszlo
- [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors, (continued)
- [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 11/13] qemu-char: add -chardev mux support, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 10/13] qemu-char: minor mux chardev fixes, Gerd Hoffmann, 2013/06/24
- [Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation, Gerd Hoffmann, 2013/06/24
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes, Michael Tokarev, 2013/06/24
- Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes,
Laszlo Ersek <=