Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

[Peter Lieven]

Am 17.06.2013 15:58, schrieb Gerd Hoffmann:
>   Hi,
> 
>>> I guess reset_keys() should skip capslock+numlock to not disturb the
>>> sync logic, can you try that?
>>
>> mhh, i might be wrong, but where could the vs->modifiers_state be not zero
>> on a new connection. I only find a g_malloc0 initializing the VNCState.
> 
> Ah, right, it is in the per-connection vnc state not in the
> server-global vnc state.  Yes, I guess we should store ledstate in
> VncDisplay then, so we can call kbd_leds() on new connections.

maybe all modifiers should be stored global?

anyway, what also seems to work is to clear capslock / numlock on disconnect
like shift,alt,ctrl if the sync logic is enabled.

Peter

> 
> cheers,
>   Gerd
> 
>