Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

[Peter Lieven]

Am 17.06.2013 14:09, schrieb Gerd Hoffmann:
> On 06/17/13 13:05, Peter Lieven wrote:
>> Am 17.06.2013 10:49, schrieb Gerd Hoffmann:
>>> On 06/17/13 10:10, Peter Lieven wrote:
>>>> Hi Gerd,
>>>>
>>>> just looking at your patch. It works fine so far, but I am curious how
>>>> to handle the lock keys? I have the problem that if I press caps lock
>>>> and then create a new vnc session with exclusive access (from another
>>>> terminal), the caps lock is still there.
>>>
>>> There is some logic for that in the vnc server, next time you press a
>>> letter key it should get synced up.  capslock+numlock can actually
>>> easier go out of sync than the other modifiers, you don't need a
>>> reconnect to trigger that:  Activate some other window so the vnc client
>>> window so it hasn't the keyboard focus, press capslock or numlock, move
>>> focus back to the vnc window.
>>
>> It seems the sync logic fails iff.
>>  Caps Lock enabled -> VNC Disconnect -> Caps Lock disabled -> VNC Reconnect.
>>  In this case the guest OS is still typing uppercase letters.
> 
> I guess reset_keys() should skip capslock+numlock to not disturb the
> sync logic, can you try that?

mhh, i might be wrong, but where could the vs->modifiers_state be not zero
on a new connection. I only find a g_malloc0 initializing the VNCState.

Peter