Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

[Stefan Hajnoczi]

On Thu, Jun 13, 2013 at 01:47:41PM +0200, Kevin Wolf wrote:
> @@ -532,6 +548,16 @@ static int qcow2_open(BlockDriverState *bs, QDict 
> *options, int flags)
>      s->use_lazy_refcounts = qemu_opt_get_bool(opts, QCOW2_OPT_LAZY_REFCOUNTS,
>          (s->compatible_features & QCOW2_COMPAT_LAZY_REFCOUNTS));
>  
> +    s->discard_passthrough[QCOW2_DISCARD_NEVER] = false,

comma instead of semicolon?

> @@ -187,6 +190,8 @@ typedef struct BDRVQcowState {
>      int qcow_version;
>      bool use_lazy_refcounts;
>  
> +    bool discard_passthrough[QCOW2_DISCARD_MAX];
> +

Neat solution to specifying discard behavior.

Stefan