[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connec
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connect |
Date: |
Fri, 14 Jun 2013 13:15:07 +0200 |
libqtest's qtest_init() connecting to the qtest socket triggers reset.
This was coded in the hope we could use the same QEMU process for
multiple tests that way. Never used. Injects an extra reset even
when it's not used, and that can mess up tests such as the one of
-boot once I'm about to add. Drop it.
Signed-off-by: Markus Armbruster <address@hidden>
---
qtest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qtest.c b/qtest.c
index 07a9612..74f1842 100644
--- a/qtest.c
+++ b/qtest.c
@@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)
switch (event) {
case CHR_EVENT_OPENED:
- qemu_system_reset(false);
+ /*
+ * We used to call qemu_system_reset() here, hoping we could
+ * use the same process for multiple tests that way. Never
+ * used. Injects an extra reset even when it's not used, and
+ * that can mess up tests, e.g. -boot once.
+ */
for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
irq_levels[i] = 0;
}
--
1.7.11.7
- Re: [Qemu-devel] [PATCH v3 04/16] vl: Rename *boot_devices to *boot_order, for consistency, (continued)
- [Qemu-devel] [PATCH v3 02/16] qemu-option: check_params() is now unused, drop it, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 01/16] vl: Clean up parsing of -boot option argument, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 10/16] boot-order-test: Cover -boot once in ppc tests, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 05/16] pc: Make -no-fd-bootchk stick across boot order changes, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connect,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 13/16] boot-order-test: Add tests for PowerPC PREP, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 08/16] boot-order-test: New; covering just PC for now, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 03/16] vl: Fix -boot order and once regressions, and related bugs, Markus Armbruster, 2013/06/14