[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with d
|
From: |
Jesse Larrew |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data |
|
Date: |
Thu, 06 Jun 2013 15:18:13 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 06/06/2013 03:09 PM, Dave Jones wrote:
> On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
>
> > > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > > + if (vi->mergeable_rx_bufs)
> > > + hdr_len = sizeof hdr->mhdr;
> > > + else
> > > + hdr_len = sizeof hdr->hdr;
> >
> > All conditionals need braces.
>
> Documentation/CodingStyle disagrees:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Dave
>
Ah, yes. This is kernel code. My mistake. :)
Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
address@hidden