[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with d
|
From: |
Dave Jones |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data |
|
Date: |
Thu, 6 Jun 2013 16:09:33 -0400 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.
Documentation/CodingStyle disagrees:
"Do not unnecessarily use braces where a single statement will do."
Dave