[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build

From: Brad Smith
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI
Date: Wed, 05 Jun 2013 14:22:13 -0400
User-agent: Mozilla/5.0 (Macintosh; PPC Mac OS X 10.5; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 TenFourFox/Debugging

On 25/05/13 5:14 AM, Michael Tokarev wrote:
24.05.2013 22:47, Brad Smith wrote:

+++ b/include/qemu-common.h
  #elif defined CONFIG_BSD
+# include <termios.h>

Kinda late nit picking about it now.

It's not.  And it's not nitpicking really, we're
carrying a ton of unnecessary #includes which slows
down compilation significantly.

I agree.

The whole this piece of #include twist was to get
declaration of openpty() or equivalent.  You just
stiffed an unrelated #include into this piece which
was okay to remove completely.  I already removed
it from several other .c files where it went from
vl.c originally, which used to have chardev code
which is now in another file.

It was not unrelated, it was necessary for the BSD
code path which utilizes openpty().

What was the original issue?  Where exactly it was
failing?  I mean, where's the _proper_ place to
fix it?

It was failing in the Gtk+ UI code due to the use
of openpty().

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]