Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

[Eduardo Habkost]

On Wed, Jun 05, 2013 at 07:29:46PM +0200, Andreas Färber wrote:
> Am 05.06.2013 19:17, schrieb Eduardo Habkost:
> > On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote:
> >> Am 05.06.2013 16:39, schrieb Igor Mammedov:
> >>> On Wed, 05 Jun 2013 15:29:08 +0200
> >>> Andreas Färber <address@hidden> wrote:
> >>>> Why is conversion of dynamic properties to static properties still
> >>>> needed after I applied a solution to override values of dynamic
> >>>> properties with -global for 1.5?
> >>> Do you mean qdev_prop_set_globals_for_type() & co?
> >>
> >> Yes.
> >>
> >>> If yes, then I recall it was acceptable hack to permit more clean
> >>> approach for compat props fixes to work. And we promised Anthony to
> >>> get rid of it when possible.
> >>
> >> Indeed, but no one talked about reverting to static properties as the
> >> solution. :) Instead I was talking about solving this very general
> >> problem at DeviceState / QOM level.
> > 
> > We have had this discussion before, and I remember Anthony saying that
> > anything set using global properties _must_ be static properties,
> > period.
> 
> Obviously I am not aware of that, might that have been an IRC discussion?!

Yeah, it was on IRC (on 2012-10-03). Quoting Anthony: "globals not
working with non-static properties is a feature, not a bug".

-- 
Eduardo