[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest i
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time |
Date: |
Mon, 22 Apr 2013 15:03:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 22/04/2013 14:43, Luiz Capitulino ha scritto:
>> >
>> > You're right. The typematic delay/rate is implemented within the i8042
>> > keyboard microcontroller (QEMU does not implement that register).
>> >
>> > It is possible that software ignores interrupts for a key that is
>> > already down, and reimplements autorepeat in software, but your patch is
>> > correct.
> But isn't this patch the equivalent of repeatedly pressing and releasing a
> key? Shouldn't this be implemented at a lower-level layer like the input
> subsystem?
No, this patch is implementing what the microcontroller does, i.e. 10
presses + 1 release. I'm not sure it is the right level to do it (the
rate/delay should be at least customizable from the board), but the
logic is right and if someone else needs more configurability we can add
it later.
Paolo
- [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/19
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Eric Blake, 2013/04/20
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Luiz Capitulino, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Gerd Hoffmann, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Gerd Hoffmann, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Anthony Liguori, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Luiz Capitulino, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- [Qemu-devel] [PATCH] ui/input.c: replace magic numbers by macros, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Eric Blake, 2013/04/22