[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest i
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time |
Date: |
Mon, 22 Apr 2013 17:20:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Hi,
> Yes, if PS/2 keyboard emulation emulated the autorepeat rate/delay, then
> the code we have in QMP would just work. However it would need to be
> done for all devices (ignoring repeated keydown events from the upper
> layers, and creating its own repeated event). So it makes sense to have
> it in common code and have keyboard devices just tell common code the
> desired rate/delay.
Yep, that'll work too.
> BTW, how do we currently handle stuck keys across migration (where the
> key-up event never reaches the guest because the key was never pressed
> in the first place on the destination)?
We don't.
>> IIRC the (ps/2) kbd controller can be programmed with rate+delay.
>
> Yes, but we ignore the command. For the PS/2 keyboard, I think what we
> send now to the guest is based on the rate/delay that is emulated in
> software by the GUI layers (for Unix it should just be X11 for all of
> SDL/VNC/Spice).
Exactly. Thats why keys getting stuck on migration isn't a big issue in
practice.
cheers,
Gerd
- [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/19
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Eric Blake, 2013/04/20
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Luiz Capitulino, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Gerd Hoffmann, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Anthony Liguori, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Luiz Capitulino, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Amos Kong, 2013/04/22
- [Qemu-devel] [PATCH] ui/input.c: replace magic numbers by macros, Amos Kong, 2013/04/22
- Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time, Eric Blake, 2013/04/22