Re: [Qemu-devel] [PATCH] block/ssh: Require libssh2 >= 1.2.8.

[Stefan Hajnoczi]

On Fri, Apr 19, 2013 at 09:16:39AM +0100, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <address@hidden>
> 
> libssh2 >= 1.2.8 is required to enable this block device (because
> that version introduced the libssh2_session_handshake call).
> 
> Change the test to use pkg-config exclusively.  If the user requests
> --enable-libssh2 and the minimum version is not available, then the
> following error is displayed:
> 
>   $ ./configure --enable-libssh2
> 
>   ERROR: libssh2 >= 1.2.8 required for --enable-libssh2
> 
> If --enable-libssh2 is not specified, then the feature is silently
> disabled if sufficiently new libssh2 is not available.
> ---
>  configure | 24 ++++--------------------
>  1 file changed, 4 insertions(+), 20 deletions(-)

Two comments:

1. This patch also drops non-pkgconfig support.  I guess this is okay.

2. RHEL 5 and Debian stable do not have libssh2 1.2.8.  Since this is a
   new feature for the QEMU 1.5 release, no one is expecting it to be
   available for old distros.  Therefore, not a problem.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan