[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic |
Date: |
Thu, 18 Apr 2013 18:51:44 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/18/2013 04:54 PM, Michael R. Hines wrote:
> On 04/18/2013 04:44 AM, Orit Wasserman wrote:
>> Hi Michael,
>>
>> I don't see you addressed any of the comment I had in v3
>> (especially the error handling)
>>
>> please, fix those
>
> I did fix them, but not all of your comments were correct,
> because I was passing errp in many places were errp
> did not supposed to belong there.
If you decide not to fix some comment you just need
to reply to the comment and explain the reason,
this makes the reviewing process easier.
>
> So, first I *removed* errp from being proliferated all over
> the entire file, which was not necessary.
>
> Then, in the places where errp is required by migration.c,
> I added new uses of errp.
That is fine as long as external rdma API use errp and the
internal always return some error code.
Also I noticed that the errors are very general for example
in qemu_rdma_connect we set the same error always it will be more
helpful to have different errors for each case. We need
errors that can help the user to understand what went wrong.
Orit
>
> There are some places, as Paolo mentioned where errp was
> written twice, which I must fix, however.
>
>
- [Qemu-devel] [PULL v4 05/11] rdma: export qemu_fflush(), (continued)
- [Qemu-devel] [PULL v4 05/11] rdma: export qemu_fflush(), mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 09/11] rdma: send pc.ram, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 11/11] rdma: add documentation, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 08/11] rdma: core logic, mrhines, 2013/04/17
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Anthony Liguori, 2013/04/18
- [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Paolo Bonzini, 2013/04/18