[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic
From: |
Michael R. Hines |
Subject: |
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic |
Date: |
Thu, 18 Apr 2013 09:54:25 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 |
On 04/18/2013 04:44 AM, Orit Wasserman wrote:
Hi Michael,
I don't see you addressed any of the comment I had in v3
(especially the error handling)
please, fix those
I did fix them, but not all of your comments were correct,
because I was passing errp in many places were errp
did not supposed to belong there.
So, first I *removed* errp from being proliferated all over
the entire file, which was not necessary.
Then, in the places where errp is required by migration.c,
I added new uses of errp.
There are some places, as Paolo mentioned where errp was
written twice, which I must fix, however.
- [Qemu-devel] [PULL v4 01/11] rdma: export yield_until_fd_readable(), (continued)
- [Qemu-devel] [PULL v4 01/11] rdma: export yield_until_fd_readable(), mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 05/11] rdma: export qemu_fflush(), mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 09/11] rdma: send pc.ram, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 11/11] rdma: add documentation, mrhines, 2013/04/17
- [Qemu-devel] [PULL v4 08/11] rdma: core logic, mrhines, 2013/04/17
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Anthony Liguori, 2013/04/18