[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic |
Date: |
Thu, 18 Apr 2013 16:52:50 +0300 |
On Thu, Apr 18, 2013 at 10:45:19AM -0400, Michael R. Hines wrote:
> On 04/18/2013 09:32 AM, Michael S. Tsirkin wrote:
> >On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote:
> >>On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote:
> >>>On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote:
> >>>>On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote:
> >>>>>The following comment applies to all of this code:
> >>>>>
> >>>>>On Wed, Apr 17, 2013 at 07:07:17PM -0400, address@hidden wrote:
> >>>>>>diff --git a/migration-rdma.c b/migration-rdma.c
> >>>>>>new file mode 100644
> >>>>>>index 0000000..1dff06f
> >>>>>>--- /dev/null
> >>>>>>+++ b/migration-rdma.c
> >>>>>>@@ -0,0 +1,2667 @@
> >>>>>>+/*
> >>>>>>+ * Copyright (C) 2013 Michael R. Hines <address@hidden>
> >>>>>>+ * Copyright (C) 2010 Jiuxing Liu <address@hidden>
> >>>>>By the way do you both really hold copyrights on this code?
> >>>>>It's not assigned to IBM?
> >>>>>If the later it should say:
> >>>>> Copyright IBM
> >>>>> Author: Michael R. Hines
> >>>>>Or some such.
> >>>>Acknowledged.
> >>>>
> >>>>>>+ *
> >>>>>>+ * RDMA protocol and interfaces
> >>>>>>+ *
> >>>>>>+ * This program is free software; you can redistribute it and/or
> >>>>>>modify
> >>>>>>+ * it under the terms of the GNU General Public License as published
> >>>>>>by
> >>>>>>+ * the Free Software Foundation; under version 2 of the License.
> >>>>>We prefer 2 or later for new code.
> >>>>Doesn't it say version 2 already?
> >>>version 2 != 'version 2 or later'. See COPYING at the top level in qemu.
> >>I'll duplicate the copyright used in Anthony's migration.c and
> >>tailor it to match.
> >Sigh. Please don't copy migration.c, that includes a legacy header.
> >If you want to make things 2 or later, just take the
> >template from COPYING. There is a section 'How to Apply These Terms to
> >Your New Programs' there. It tells you exactly what to put in the code.
> >It's 2013 so if you want to be hip you can replace the FSF snail mail
> >address with " if not, see http://www.gnu.org/licenses/. "
> >which is a bit shorter.
>
> OK, I read the file, please review this version,
> and I will paste into migration-rdma.c:
Sure, that's what COPYING says. So yea, just get ack from
Jiuxing Liu.
> /*
> * RDMA Migration Protocol and Interfaces
> *
> * Copyright (C) 2013 Michael R. Hines <address@hidden>
> * Copyright (C) 2010 Jiuxing Liu <address@hidden>
Except you said you will change this to Copyright IBM + Author.
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> * the Free Software Foundation; either version 2 of the License, or
> * (at your option) any later version.
>
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> *
> *
> * You should have received a copy of the GNU General Public
> License along
> * with this program; if not, write to the Free Software
> Foundation, Inc.,
> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
>
> >
> >>>>>I'm guessing you need approval from Jiuxing Liu for this,
> >>>>>pls make him ack license change.
> >>>>He approves. He doesn't work for IBM anymore.
> >>>Does he approve version 2 or version 2 or later?
> >>>
> >>It doesn't matter - his contributions were made at IBM and he
> >>doesn't work for IBM anymore.
> >It's considered polite not to ignore author's wishes wrt licensing.
> >It's best to contact and get the ack if possible. If not, please tell
> >the list and we'll consider the options.
> >
> >
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, (continued)
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Anthony Liguori, 2013/04/18
[Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Paolo Bonzini, 2013/04/18
Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Michael R. Hines, 2013/04/18
Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Anthony Liguori, 2013/04/18
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Eric Blake, 2013/04/18
Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support, Anthony Liguori, 2013/04/17
Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support, Michael S. Tsirkin, 2013/04/18