[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/gtk: fix build on GTK 2.18 and older
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] ui/gtk: fix build on GTK 2.18 and older |
Date: |
Mon, 25 Feb 2013 15:23:28 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 22, 2013 at 07:51:30AM -0600, Anthony Liguori wrote:
> Reported-by: Gerd Hoffman <address@hidden>
> Suggested-by: Daniel Berrange <address@hidden>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
> ui/gtk.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 5f91de4..46e30b9 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -122,6 +122,10 @@ typedef struct GtkDisplayState
>
> static GtkDisplayState *global_state;
>
> +#if !GTK_CHECK_VERSION(2, 18, 0)
This version check is wrong - it needs to be "2, 20, 0", so that
any <= 2.18.x gets the compat wrapper.
> +#define gtk_widget_get_realized(widget) GTK_WIDGET_REALIZED(widget)
> +#endif
> +
I've sent a patch to fix this & the other problems in 2.18
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|