Re: [Qemu-devel] [PATCH] ui/gtk: fix build on GTK 2.18 and older

[Gerd Hoffmann]

  Hi,

> +#if !GTK_CHECK_VERSION(2, 18, 0)
> +#define gtk_widget_get_realized(widget) GTK_WIDGET_REALIZED(widget)
> +#endif

Not working:

  CC    ui/gtk.o
cc1: warnings being treated as errors
/home/kraxel/projects/qemu/ui/gtk.c: In function ‘gd_draw_event’:
/home/kraxel/projects/qemu/ui/gtk.c:355: error: implicit declaration of
function ‘gtk_widget_get_realized’
/home/kraxel/projects/qemu/ui/gtk.c:355: error: nested extern
declaration of ‘gtk_widget_get_realized’

Oh, and I just saw there is more, GDK_KEY_* seems to be new too:

/home/kraxel/projects/qemu/ui/gtk.c: In function ‘gd_vc_init’:
/home/kraxel/projects/qemu/ui/gtk.c:885: error: ‘GDK_KEY_2’ undeclared
(first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:885: error: (Each undeclared
identifier is reported only once
/home/kraxel/projects/qemu/ui/gtk.c:885: error: for each function it
appears in.)
/home/kraxel/projects/qemu/ui/gtk.c: In function ‘gd_create_menus’:
/home/kraxel/projects/qemu/ui/gtk.c:1009: error: ‘GDK_KEY_f’ undeclared
(first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:1018: error: ‘GDK_KEY_plus’
undeclared (first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:1024: error: ‘GDK_KEY_minus’
undeclared (first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:1030: error: ‘GDK_KEY_0’ undeclared
(first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:1045: error: ‘GDK_KEY_g’ undeclared
(first use in this function)
/home/kraxel/projects/qemu/ui/gtk.c:1055: error: ‘GDK_KEY_1’ undeclared
(first use in this function)
gmake: *** [ui/gtk.o] Error 1

cheers,
  Gerd