Re: [Qemu-devel] [PATCH] ui/gtk: fix build on GTK 2.18 and older

[Daniel P. Berrange]

On Fri, Feb 22, 2013 at 08:53:13AM -0600, Anthony Liguori wrote:
> Gerd Hoffmann <address@hidden> writes:
> 
> >   Hi,
> >
> >> +#if !GTK_CHECK_VERSION(2, 18, 0)
> >> +#define gtk_widget_get_realized(widget) GTK_WIDGET_REALIZED(widget)
> >> +#endif
> >
> > Not working:
> >
> >   CC    ui/gtk.o
> > cc1: warnings being treated as errors
> > /home/kraxel/projects/qemu/ui/gtk.c: In function ‘gd_draw_event’:
> > /home/kraxel/projects/qemu/ui/gtk.c:355: error: implicit declaration of
> > function ‘gtk_widget_get_realized’
> > /home/kraxel/projects/qemu/ui/gtk.c:355: error: nested extern
> > declaration of ‘gtk_widget_get_realized’
> >
> > Oh, and I just saw there is more, GDK_KEY_* seems to be new too:
> 
> GDK_KEY_ is most definitely not new.  Is this RHEL5?

Actually it is new.  GTK3 introduced GDK_KEY_xxx symbols. Originally
GTK2 was using just GTK_xxx. The most recent versions of GTK2 have
now also introduced GTK_KEY_xxx, but kept GTK_xxx for compat. Hence
why we see the failures on 2.18 GTK which only supports GTK_xxx
symbols. I've sent a patch to fix this.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|