Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

[Anthony Liguori]

Kevin Wolf <address@hidden> writes:

> Am 11.02.2013 22:14, schrieb Anthony Liguori:
>> Paolo Bonzini <address@hidden> writes:
>> 
>>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>>>> Applied.  Thanks.
>>>>
>>>> Regards,
>>>>
>>>> Anthony Liguori
>>>
>>> I guess this was a mistake, please revert.
>> 
>> No, it wasn't.  The patch was reviewed and tested.  What's the problem.
>> It's proposed for 1.4 so it's now or never.

(Note, I already have a revert queued, tested over night, and will push
this morning)

> The problem is that the test failed. Why do we even test things if we
> commit anyway when the test fails?

That wasn't at all clear to me.  Besides, by the time Jeff's note came,
the commit was already pushed.  The 'Thanks' note was delayed compared
to the actual push.

> And why do we have subsystem trees when a committer comes (without even
> having taken part in the discussion) and applies patches that the
> subsystem maintainers are very obviously not happy with? 

There are two block maintainers.  One of the block maintainers, Stefan,
offered a Reviewed-by.

> If you like,
> you can have the block subsystem back, just send - or better just apply
> - a patch against MAINTAINERS.

The real problem here was that it was not clear to me whether to expect
a pull request for -rc2 or not and from whom.  I received very few pull
requests during this -rc cycle and most submaintainers have asked me to
apply patches directly because of the short cycle.

In fact, I reached out twice on IRC attempting to clarify whether I was
going to get a block pull request for -rc2 and got no response from you
or Stefan.

Regards,

Anthony Liguori