qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories"
Date: Mon, 11 Feb 2013 21:09:45 +0000

On 11 February 2013 19:23, Andreas Färber <address@hidden> wrote:
> Am 11.02.2013 17:41, schrieb Peter Maydell:
>> +void qemu_print_log_usage(FILE *f)
>> +{
>> +    const CPULogItem *item;
>
> If this gets resubmitted or included in a PULL, a while line here would
> match our usual separate-variables-from-statements convention.

You mean a blank line? Sure, I can add one.

>> +    fprintf(f, "Log items (comma separated):\n");
>> +    for (item = cpu_log_items; item->mask != 0; item++) {
>> +        fprintf(f, "%-10s %s\n", item->name, item->help);
>> +    }
>> +}

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]