[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories" |
Date: |
Mon, 11 Feb 2013 21:09:45 +0000 |
On 11 February 2013 19:23, Andreas Färber <address@hidden> wrote:
> Am 11.02.2013 17:41, schrieb Peter Maydell:
>> +void qemu_print_log_usage(FILE *f)
>> +{
>> + const CPULogItem *item;
>
> If this gets resubmitted or included in a PULL, a while line here would
> match our usual separate-variables-from-statements convention.
You mean a blank line? Sure, I can add one.
>> + fprintf(f, "Log items (comma separated):\n");
>> + for (item = cpu_log_items; item->mask != 0; item++) {
>> + fprintf(f, "%-10s %s\n", item->name, item->help);
>> + }
>> +}
-- PMM
- [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 3/6] qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories", Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(), Peter Maydell, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Richard Henderson, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Stefan Hajnoczi, 2013/02/12
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/13