[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log()
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log() |
Date: |
Mon, 11 Feb 2013 20:29:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 11.02.2013 17:41, schrieb Peter Maydell:
> The set_cpu_log() function in cpus.c is a fairly simple wrapper
> which is only called from one location. Just inline the code
> into vl.c, since there is no need to indirect it via cpus.c
> and the handling of the error case is more appropriate to vl.c.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> cpus.c | 12 ------------
> include/sysemu/cpus.h | 1 -
> vl.c | 9 ++++++++-
> 3 files changed, 8 insertions(+), 14 deletions(-)
Reviewed-by: Andreas Färber <address@hidden>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename, (continued)
- [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories", Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(), Peter Maydell, 2013/02/11
- Re: [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(),
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Richard Henderson, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Stefan Hajnoczi, 2013/02/12
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/13
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/16