[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_file
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename |
Date: |
Mon, 11 Feb 2013 20:21:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 11.02.2013 17:41, schrieb Peter Maydell:
> The qemu_log() functionality is no longer specific to TCG CPU debug logs.
> Rename cpu_set_log_filename() to qemu_set_log_filename() and drop the
> pointless wrapper set_cpu_log_filename().
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> bsd-user/main.c | 2 +-
> cpus.c | 5 -----
> include/qemu/log.h | 2 +-
> include/sysemu/cpus.h | 1 -
> linux-user/main.c | 4 ++--
> monitor.c | 2 +-
> qemu-log.c | 2 +-
> vl.c | 2 +-
> 8 files changed, 7 insertions(+), 13 deletions(-)
Reviewed-by: Andreas Färber <address@hidden>
Especially happy to see another odd cpu_* function go away.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 3/6] qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename, Peter Maydell, 2013/02/11
- Re: [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename,
Andreas Färber <=
- [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories", Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(), Peter Maydell, 2013/02/11