Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

[Stefan Hajnoczi]

On Mon, Feb 27, 2012 at 2:49 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini <address@hidden> wrote:
>> On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote:
>> 3) blkverify in the future could add callbacks to create snapshots or
>> load/save imgstate, and forward them to the test file; this doesn't make
>> sense for blkmirror.
>
> I guess what I'm saying is, if we need to copy-paste in order to fork
> them in the future that's fine, but why maintain duplicates in the
> mean-time?  Please make the codebase nice today.  We can always extend
> it in the future, we're not forced to keep them unified forever if it
> turns out we want to split them.  But as it stands they are
> essentially the same thing.

BTW, I feel that I may just be missing context on what the plans are
around mirroring and block migration.  Is there a plan or discussions
that haven't hit qemu-devel (maybe they were done in ovirt or
internally)?

Stefan