[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
From: |
Federico Simoncelli |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver |
Date: |
Thu, 23 Feb 2012 11:51:37 -0500 (EST) |
----- Original Message -----
> From: "Stefan Hajnoczi" <address@hidden>
> To: "Federico Simoncelli" <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Sent: Thursday, February 23, 2012 5:28:23 PM
> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
>
> On Thu, Feb 23, 2012 at 4:20 PM, Federico Simoncelli
> <address@hidden> wrote:
> > ----- Original Message -----
> >> From: "Stefan Hajnoczi" <address@hidden>
> >> To: "Federico Simoncelli" <address@hidden>
> >> Cc: address@hidden, address@hidden, address@hidden
> >> Sent: Thursday, February 23, 2012 5:18:41 PM
> >> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
> >>
> >> On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi
> >> <address@hidden>
> >> wrote:
> >> > By the way, this code does not build against qemu.git/master.
> >> > It
> >> > uses
> >> > interfaces which have been dropped.
> >>
> >> Ah, I see you changed that in Patch 2/3. Please don't do that,
> >> it's
> >> hard to review and breaks git-bisect.
> >
> > Squashing is easy (anyone could do it at the commit phase),
> > reviewing
> > is hard (if you hide your changes in someone else's code).
>
> I don't care if you or Marcelo wrote it, I want to see a coherent
> piece of code.
>
> The way to do it is to merge the g_malloc() and BlockDriver interface
> changes into this path. Then you have not snuck any significant
> changes into Marcelo's code.
Well for example I'd have snuck the qemu_vmalloc/qemu_vfree mistake.
> Keep the BDRV_O_NO_BACKING separate.
Ok, thanks.
--
Federico
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, (continued)
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, Paolo Bonzini, 2012/02/23
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, Federico Simoncelli, 2012/02/23
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, Paolo Bonzini, 2012/02/23
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, Federico Simoncelli, 2012/02/23
- Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev, Paolo Bonzini, 2012/02/23
[Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Federico Simoncelli, 2012/02/22
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Federico Simoncelli, 2012/02/23
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Stefan Hajnoczi, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Paolo Bonzini, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Stefan Hajnoczi, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Paolo Bonzini, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Stefan Hajnoczi, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Paolo Bonzini, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Stefan Hajnoczi, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Stefan Hajnoczi, 2012/02/27
Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, Paolo Bonzini, 2012/02/27