Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

[Andreas Färber]

Am 22.02.2012 15:02, schrieb Juan Quintela:
> Peter Maydell <address@hidden> wrote:
>> On 22 February 2012 10:15, Igor Mitsyanko <address@hidden> wrote:
>>> This patchset cleans up and optimizes vmstate implementation.
>>>
>>> Patch 1 is a trivial bug fixing.
>>> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation
>>> to uint32_t.
>>> Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency
>>> on NEED_CPU_H is droped, I failed to understand why it was presented at all.
>>
>> So if we apply patches 1-3 (which all look plausible) then the only
>> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as
>> I can see.
>>
>> This leaves me wondering if we shouldn't just put it actually in
>> target-i386/machine.c as a convenience macro for that specific CPU
>> to avoid having to have more #ifdef TARGET_X86_64s. (I note that
>> the machine.c code is already pretty inconsistent, eg lstar and
>> cstar are defined as target_ulong and saved with VMSTATE_UINT64.)
> 
> With my cpu-vmstate patches, all 32/64 bit cpus use it.

NB: Your cpu-vmstate patches were not applied so far and they appear to
conflict with the plans we've made for redesigning cp15 on ARM: We want
to convert today's static fields to some list and were hoping to have a
mapping function for backwards compatibility. That works easiest in
imperative code.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg